Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Use GitHub Actions CI #41

Merged
merged 1 commit into from
Jul 15, 2022
Merged

MNT Use GitHub Actions CI #41

merged 1 commit into from
Jul 15, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Jul 5, 2022
Closed
40 tasks
@emteknetnz emteknetnz force-pushed the pulls/3.1/module-standards branch 3 times, most recently from 11a2aea to b8672c1 Compare July 14, 2022 00:00
GuySartorelli
GuySartorelli requested changes Jul 14, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add a phpcs file for linting

@emteknetnz emteknetnz force-pushed the pulls/3.1/module-standards branch from b8672c1 to edbc016 Compare July 14, 2022 23:28
@emteknetnz
Copy link
Member Author

Updated

@GuySartorelli
Copy link
Member

I'm confused... you've renamed the phpunit file (which I don't think was necessary) but didn't add a phpcs file?

@emteknetnz emteknetnz force-pushed the pulls/3.1/module-standards branch from edbc016 to 9aebe84 Compare July 15, 2022 00:33
@emteknetnz
Copy link
Member Author

Have added the phpcs config file

GuySartorelli
GuySartorelli approved these changes Jul 15, 2022
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like codesniffer needs to be added too, but that can be handled separately since we're treating failures separately from adding ci config.

@GuySartorelli GuySartorelli merged commit 09acdf7 into silverstripe:3.1 Jul 15, 2022
@GuySartorelli GuySartorelli deleted the pulls/3.1/module-standards branch July 15, 2022 00:48
@GuySartorelli GuySartorelli mentioned this pull request Jul 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli